Conformity of client intereptor(s) with the official grpc.*ClientInterceptor-interfaces #3384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rceptor-interfaces Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
11 tasks
|
I feel like this is a bigger issue that is known, especially because the means of resolve is so hard to find. The issue is here. Is there any way this can get some attention so that it is merged in a timely manner? |
|
Hello @Sovietaced Thanks for the PR. We are struggling with the instrumentation of PubSub clients on GCP due to this issue, do you know how to get some momentum on this PR? |
|
Tagging @aabmass as for Google, since this is affecting GCP PubSub |
I do not know how to get momentum on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a reworked version of #1583
I started from scratch and ported over @CoLa5's changes so that I could understand what the code was doing. I had to make things work with the more recently added request/response hooks.
Currently, the OpenTelemetryClientInterceptor is based on an external implementation of grpc client interceptors whose source code lies in the package grpcext.
To support the official grpc.UnaryUnaryClientInterceptor-, grpc.UnaryStreamClientInterceptor-, grpc.StreamUnaryClientInterceptor-, and grpc.StreamStreamClientInterceptor-interface, which are supported officially in grpc since v1.8.0, the source code of the _client.py-module is adapted.
Hereby, the design of the _client.py-module orientates itself strongly on the design of the _aio_client.py-module. Thus, the external implementation of the grpc client interceptors can be removed (package grpcext). Also, the RpcInfo-class in the utilities.py-module is not required any more.
The _aio_client.py-module must be adapted so that the _BaseAioClientInterceptor becomes independent of the _BaseClientInterceptor.
The test_client_interceptor_trace_context_propagation-tests are adapted according to the same test in the test_aio_client_interceptor.py-module to remove the dependency on the external implementation of the grpc client interceptors, which are located in the package grpcext.
The documentation of the code in the init.py is adapted accordingly.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.